justintsus-experiment Public
// The search query language of the Issues and Pull requests lists (apps/web/src/search): terms,// errors and their spans, the limits, and the canonical form. Run `npm run tsus:web` first (npm run// test:unit does): api.ts imports the compiled .tsus modules.import assert from "node:assert/strict";import test from "node:test";import { parseQuery, serializeQuery, toSql, type QueryErrorCode, type Target } from "../../../apps/web/src/search/api.ts";function canon(input: string, target: Target = "issues"): string { const r = parseQuery(input, target); assert.ok(r.ok, `${input}: ${JSON.stringify(r)}`); return serializeQuery(r.query);}type E = [QueryErrorCode, number, number];function errs(input: string, target: Target = "issues"): E[] { const r = parseQuery(input, target); assert.ok(!r.ok, `${input} parsed`); for (const e of r.errors) assert.ok(e.message.length > 0); return r.errors.map((e) => [e.code, e.start, e.end]);}test("the canonical form normalizes keys and values and keeps the order", () => { assert.equal(canon(""), ""); assert.equal(canon(" \t "), ""); assert.equal(canon("IS:Open"), "is:open"); assert.equal(canon('label:" Needs Review "'), 'label:"needs review"'); assert.equal(canon("author:@ME"), "author:@me"); assert.equal(canon("updated:<007D"), "updated:<7d"); assert.equal(canon("created:>=2026-10-01 created:2026-10-01..*"), "created:>=2026-10-01 created:2026-10-01..*"); assert.equal(canon("Sort:Updated-ASC"), "sort:updated-asc"); assert.equal(canon("author:0F8FAD5B-D9CB-469F-A165-70867728950E"), "author:0f8fad5b-d9cb-469f-a165-70867728950e"); assert.equal(canon("author:Docs-Bot"), "author:docs-bot"); assert.equal(canon("NO:LABEL"), "no:label"); assert.equal(canon('is:"closed"'), "is:closed"); assert.equal(canon("crash is:open #12"), "crash is:open #12");});test("free text is quoted only when it has to be", () => { assert.equal(canon('"bug"'), "bug"); assert.equal(canon('"label:x"'), '"label:x"'); assert.equal(canon("-"), '"-"'); assert.equal(canon('"-x"'), '"-x"'); assert.equal(canon('"#12"'), '"#12"'); assert.equal(canon('"#0"'), "#0"); assert.equal(canon("12:30 a1:b :x"), "12:30 a1:b :x"); assert.equal(canon('"two words"'), '"two words"'); assert.equal(canon('" padded "'), '" padded "'); assert.equal(canon('"a\\"b" "c\\\\d" "e\\f"'), '"a\\"b" c\\d e\\f'); assert.equal(canon("--x"), '-"-x"'); assert.equal(canon('-"-"'), '-"-"');});test("negation, numbers and duplicates", () => { assert.equal(canon("-label:bug -is:closed -crash"), "-label:bug -is:closed -crash"); assert.equal(canon("bug bug \"bug\" BUG"), "bug BUG"); assert.equal(canon("is:open IS:OPEN -is:open"), "is:open -is:open"); assert.equal(canon("sort:created-asc sort:created-asc"), "sort:created-asc"); assert.equal(canon("label:a label:A"), "label:a"); assert.equal(canon("#7 #7"), "#7"); assert.equal(canon("#123456789"), "#123456789"); assert.equal(canon("#1234567890"), "#1234567890");});test("each invalid term is one error spanning the whole term, in input order", () => { assert.deepEqual(errs("assignee:me repo:x milestone:1"), [["unknown_qualifier", 0, 11], ["unknown_qualifier", 12, 18], ["unknown_qualifier", 19, 30]]); assert.deepEqual(errs("http://x"), [["unknown_qualifier", 0, 8]]); assert.deepEqual(errs("label:bug no:label", "pulls"), [["unsupported_qualifier", 0, 9], ["unsupported_qualifier", 10, 18]]); assert.deepEqual(errs("review-requested:@me"), [["unsupported_qualifier", 0, 20]]); assert.deepEqual(errs('label: is:""'), [["empty_value", 0, 6], ["empty_value", 7, 12]]); assert.deepEqual(errs("-no:label -sort:created-asc -created:2026-01-01 -updated:<1d"), [ ["negation_not_allowed", 0, 9], ["negation_not_allowed", 10, 27], ["negation_not_allowed", 28, 47], ["negation_not_allowed", 48, 60], ]); assert.deepEqual(errs("-#5"), [["negation_not_allowed", 0, 3]]); assert.deepEqual(errs('"" " "'), [["empty_value", 0, 2], ["empty_value", 3, 7]]); assert.equal(canon("is:merged is:draft", "pulls"), "is:merged is:draft"); assert.equal(canon('"x y" -"a\\\\"'), '"x y" -a\\');});test("the checks of a qualifier run in order", () => { // unknown before anything; unsupported before empty; empty before negation; negation before the value assert.deepEqual(errs("-assignee:"), [["unknown_qualifier", 0, 10]]); assert.deepEqual(errs("-label:", "pulls"), [["unsupported_qualifier", 0, 7]]); assert.deepEqual(errs("-sort:"), [["empty_value", 0, 6]]); assert.deepEqual(errs("-sort:nonsense"), [["negation_not_allowed", 0, 14]]); assert.deepEqual(errs("is:merged is:draft"), [["bad_value", 0, 9], ["bad_value", 10, 18]]); assert.deepEqual(errs("sort:comments-desc", "pulls"), [["bad_value", 0, 18]]); assert.deepEqual(errs("no:labels"), [["bad_value", 0, 9]]);});test("labels and user references", () => { assert.deepEqual(errs("label:<b> label:-x"), [["bad_value", 0, 9], ["bad_value", 10, 18]]); assert.equal(canon(`label:${"a".repeat(32)}`), `label:${"a".repeat(32)}`); assert.deepEqual(errs(`label:${"a".repeat(33)}`), [["bad_value", 0, 39]]); assert.equal(canon("label:v1.2_x-y"), "label:v1.2_x-y"); assert.deepEqual(errs("author:@someone author:a_b"), [["bad_value", 0, 15], ["bad_value", 16, 26]]); assert.deepEqual(errs(`author:${"a".repeat(40)}`), [["bad_value", 0, 47]]); assert.equal(canon(`author:${"a".repeat(39)}`), `author:${"a".repeat(39)}`); assert.equal(canon("review-requested:@me", "pulls"), "review-requested:@me");});test("quotes", () => { assert.equal(canon('label:"needs review"'), 'label:"needs review"'); assert.equal(canon('LABEL:"x"'), "label:x"); assert.deepEqual(errs('a"b c" d'), [["unexpected_quote", 0, 3], ["unexpected_quote", 4, 6]]); assert.deepEqual(errs('"abc"d e'), [["unexpected_quote", 0, 6]]); assert.deepEqual(errs('label:"x"y'), [["unexpected_quote", 0, 10]]); assert.deepEqual(errs('label:a"b"'), [["unexpected_quote", 0, 10]]); assert.deepEqual(errs('ok "never closed'), [["unterminated_quote", 3, 16]]); assert.deepEqual(errs('label:"x y'), [["unterminated_quote", 0, 10]]); assert.deepEqual(errs('"escaped \\" quote'), [["unterminated_quote", 0, 17]]); // parsing stops at an unterminated quote; errors before it are kept assert.deepEqual(errs('assignee:x "a b c'), [["unknown_qualifier", 0, 10], ["unterminated_quote", 11, 17]]); // a negated quoted term includes its "-" assert.deepEqual(errs('-"x'), [["unterminated_quote", 0, 3]]);});test("a second, different sort: is a conflict", () => { assert.deepEqual(errs("sort:created-asc bug sort:updated-desc"), [["conflict", 21, 38]]); assert.deepEqual(errs("sort:x sort:created-asc"), [["bad_value", 0, 6]]);});test("dates", () => { for (const v of ["2026-10-01", ">2026-10-01", ">=2026-10-01", "<2026-10-01", "<=2026-10-01", "2026-10-01..2026-10-31", "2026-10-01..2026-10-01", "2026-10-01..*", "*..2026-10-31", "<7d", "<=1h", ">2w", ">=9999d", "1970-01-01", "9999-12-31", "2024-02-29"]) { assert.equal(canon(`created:${v}`), `created:${v}`); } assert.equal(canon("updated:<0001H"), "updated:<1h"); for (const v of ["7d", "=2026-10-01", "*..*", "2026-10-31..2026-10-01", "2026-02-30", "2025-02-29", "1969-12-31", "2026-1-01", "26-10-01", "<0d", "<10000d", "<7m", "<7", "2026-10-01..7d", ">2026-10-01..*", "2026-10-01T00:00", "<<7d", "2026-10-01...2026-10-02"]) { assert.deepEqual(errs(`updated:${v}`), [["bad_date", 0, 8 + v.length]], v); }});test("limits are checked first and reported alone", () => { const long = "a ".repeat(600); assert.deepEqual(errs(long), [["too_long", 0, long.length]]); assert.equal(canon("a".repeat(1024)), "a".repeat(1024)); const words = Array.from({ length: 33 }, (_, i) => `w${i}`); const input = `${words.join(" ")} assignee:x`; assert.deepEqual(errs(input), [["too_many_terms", input.indexOf("w32"), input.length]]); // counted as written: duplicates and invalid terms count assert.deepEqual(errs(`${"x ".repeat(32)}assignee:y`), [["too_many_terms", 64, 74]]); assert.ok(parseQuery(`${"x ".repeat(32)}`, "issues").ok);});test("the canonical form round-trips, for random inputs too", () => { const pieces = [ "is:open", "IS:closed", "-is:open", "is:merged", "is:draft", "label:bug", 'label:"Needs Review"', "-label:x", "no:label", "author:@me", "author:bot-1", "review-requested:@ME", "sort:updated-asc", "created:<7d", "updated:2026-01-01..*", "#4", "-#4", "bug", '"a b"', '"-"', "-", "--x", '"x\\"y"', '"a\\\\"', "12:30", ":x", "a1:b", '"label:x"', "-crash", '"#5"', "OR", " ", " ", "é", "100%", "a_b", "x\\y", ]; let seed = 7; const rnd = (n: number) => ((seed = (seed * 1103515245 + 12345) % 2147483648), seed % n); for (let i = 0; i < 3000; i++) { const target: Target = rnd(2) ? "issues" : "pulls"; const x = Array.from({ length: rnd(8) }, () => pieces[rnd(pieces.length)]).join(rnd(3) ? " " : " "); const r = parseQuery(x, target); if (!r.ok) continue; const c = serializeQuery(r.query); const r2 = parseQuery(c, target); assert.ok(r2.ok, `${x} -> ${c}`); assert.equal(serializeQuery(r2.query), c); const ctx = { repoId: "r", orgId: "o", viewerId: "v", now: 1_800_000_000_000 }; assert.deepEqual(toSql(r2.query, ctx), toSql(r.query, ctx)); }});test("parseQuery never throws", () => { const chars = ['"', "\\", "-", ":", "#", " ", "a", "l", "1", " ", "*", ".", "<", ">", "="]; let seed = 11; const rnd = (n: number) => ((seed = (seed * 1103515245 + 12345) % 2147483648), seed % n); for (let i = 0; i < 3000; i++) { const x = Array.from({ length: rnd(20) }, () => chars[rnd(chars.length)]).join(""); for (const t of ["issues", "pulls"] as const) { const r = parseQuery(x, t); if (r.ok) continue; let at = -1; for (const e of r.errors) { assert.ok(e.start >= 0 && e.end <= x.length && e.start < e.end && e.start >= at, `${JSON.stringify(x)}: ${JSON.stringify(r.errors)}`); at = e.end; } } }});